Best Patterns and Practices for Error Handling?

tleish · December 4, 2021, 2:50pm

Not an immediate solution, but I suggest you review:

The discussion in this ticket

Ability to override frame-target from server response

opened 05:24AM - 23 Apr 21 UTC

Currently if the response from turbo requests returns a redirect response whilst… inside a frame, there is no way for the server side to conditionally control what turbo to do with the response, eg. force a full page refresh with target="_top" There are use cases especailly for modal windows where upon succesful save we would want to perform a redirect back to the index page, where as 422 response would do the normal turbo frame replacement within current frame. It would be nice to support something like this, which will allow us to control targets from serverside to frame targets by setting frame target via the http response headers. ``` if @record.save response.headers["Turbo-Frame"] = "_top" redirect_to settings_locations_url else render partial: 'form', status: :unprocessable_entity end ``` What everyones thoughts are on this? or is there something I am missing to make this easier.

and this PR

github.com/hotwired/turbo

Introduce `turbo:frame-missing` event

hotwired:main ← seanpdoyle:missing-frame-in-response

opened 08:31PM - 14 Nov 21 UTC

seanpdoyle

+99 -24

Closes [hotwired/turbo#432][] Follow-up to [hotwired/turbo#94][] Follow-up to …[hotwired/turbo#31][] When a response from _within_ a frame is missing a matching frame, fire the `turbo:frame-missing` event. There is an existing [contract][] that dictates a request from within a frame stays within a frame. However, if an application is interested in reacting to a response without a frame, dispatch a `turbo:frame-missing` event. The event's `target` is the `FrameElement`, and the `detail` contains the `fetchResponse:` key. Unless it's canceled (by calling `event.preventDefault()`), Turbo Drive will visit the frame's URL as a full-page navigation. The event listener is also a good opportunity to change the `<turbo-frame>` element itself to prevent future missing responses. For example, if the reason the frame is missing is access (an expired session, for example), the call to `visit()` can be made with `{ action: "replace" }` to remove the current page from Turbo's page history. [contract]: https://github.com/hotwired/turbo/issues/94#issuecomment-756968205 [hotwired/turbo#432]: https://github.com/hotwired/turbo/issues/432 [hotwired/turbo#94]: https://github.com/hotwired/turbo/issues/94 [hotwired/turbo#31]: https://github.com/hotwired/turbo/issues/31

Topic		Replies	Views
Error Handling: Best Practices/Patterns?	1	1164	December 16, 2021
How to deal with 500 in the frame?	5	4038	February 7, 2023
Turbo-rails 0.5.3 form validation errors	11	4692	July 6, 2021
"Error: rendering is already in progress" when trying to perform Turbo navigation from submit-end event handler	0	638	September 18, 2021
How to handle form errors	5	4574	February 18, 2019

Best Patterns and Practices for Error Handling?

Related topics